davsclaus opened a new pull request, #3285:
URL: https://github.com/apache/camel-kamelets/pull/3285

   Part of #3280: the Kamelet options that the merged Camel fixes make possible.
   
   **Draft until a Camel 4.24.0-SNAPSHOT with these fixes is published.** The 
latest snapshot predates them, so CI fails until then:
   - the build validates the `from` parameters of 
`azure-storage-datalake-source` against the Camel catalog;
   - the new Citrus tests use the options.
   
   I tested it locally against a reactor build of apache/camel main.
   
   | Kamelet | New option | Camel |
   |---|---|---|
   | `nominatim-geocode-action` | `language`, sent to Nominatim as 
`accept-language` | CAMEL-27200 (apache/camel#30433) |
   | `pulsar-sink` | `batcherBuilder`: `DEFAULT` or `KEY_BASED`, for a 
`Key_Shared` subscription | CAMEL-27197 (#30434) |
   | `aws-lambda-sink` | `invocationType` (`RequestResponse`, `Event`, 
`DryRun`) and `logType` (`Tail`) | CAMEL-27178 (#30438) |
   | `aws-timestream-query-sink` | `queryAllPages` | CAMEL-27179 (#30439) |
   | `azure-storage-datalake-source` | `deleteAfterRead` | CAMEL-27181 (#30440) 
|
   
   - **No change without the options:** each option is passed only when it is 
set (`{{?...}}`), with no default in the Kamelet, so these Kamelets behave as 
before and still work on an older Camel.
   - **Descriptions:** the sentences that said what these Kamelets could not do 
now say how the new option changes it: Lambda "cannot be called 
asynchronously", Timestream "only the first page is returned", and Data Lake 
"neither deletes nor moves the files".
   
   **A change that comes with Camel 4.24, without this PR:** CAMEL-27200 makes 
`language` default to `en` in camel-geocoder. So `nominatim-geocode-action` 
answers in English from Camel 4.24 on, where Nominatim used to answer in the 
local language of the place. The description now says so. Setting `language` 
asks for another language. This needs a line in the upgrade notes (#3190).
   
   ### Tests
   New Citrus tests, one per option, next to the existing tests of these 
Kamelets:
   - `aws-lambda-sink-async-route`: the call asks for `X-Amz-Invocation-Type: 
Event`, and the answer is status 202 with an empty body.
   - `aws-timestream-query-sink-all-pages-route`: the second request carries 
the `NextToken` of the first answer, and the answer holds the rows of both 
pages.
   - `azure-storage-datalake-source-delete-route`: the file is read, then 
deleted (`HEAD` gives 404).
   - `nominatim-geocode-action-language-route`: Nominatim gets 
`accept-language=de`. The existing test now checks the default 
`accept-language=en`.
   - `pulsar-sink-key-based-route`: with batching and `KEY_BASED`, the message 
arrives with its key.
   
   **Results:** `AwsIT#awsLambda+awsTimestream`, `CommonIT#geo`, 
`MessagingIT#pulsar` and `AzureIT`: 26 of 26 pass. `./mvnw clean install` from 
the root passes, run twice.
   
   Still to come, when their Camel PRs are merged: `google-storage-sink` 
`storageClass` (apache/camel#30436, as `objectStorageClass`) and 
`aws-bedrock-text-sink` `converse` (apache/camel#30441).
   
   _Claude Code on behalf of Claus Ibsen_
   
   🤖 Generated with [Claude Code](https://claude.com/claude-code)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to