ramu11 commented on PR #30345:
URL: https://github.com/apache/camel/pull/30345#issuecomment-6998039454

   > Thanks, the recipes are carefully written. Things I checked:
   > 
   > * The option names and class names are correct 
(`KafkaIdempotentRepository` setters, `GroupedBodyAggregationStrategy`, 
throttle `mode`, `inheritErrorHandler`).
   > * All the linked camel-jbang-examples paths exist.
   > * `onException`/`errorHandler` and `saga`/`transacted` sit in the right 
place.
   > * The delivery caveats (at-least-once outbox, saga durability, circuit 
breaker not inheriting the error handler) are good to have.
   > 
   > Some points:
   > 
   > 1. **Nothing uses the file yet.** `patterns/recipes.json` has no 
`CamelCatalog` accessor (compare `chaosModelJSon()`), and no MCP tool or CLI 
reads it. It also partly overlaps the existing `eip-samples.json` behind 
`camel_catalog_sample` (`CatalogSamples` in camel-jbang) and the examples 
metadata behind `camel_catalog_examples`. How do you plan to expose it: an API 
accessor plus an MCP tool, or folding it into the existing samples? It would be 
good to settle that before merging so we don't end up with two sample catalogs.
   > 2. **The file-polling recipe sends to `direct:process-invoice`, but no 
route consumes it** (`recipes.json:194`). As written, every file fails with "No 
consumers available" and ends up in `failed/`. The other recipes ship stub 
routes, so please add one here too.
   > 3. **Some `recommendedOptions[].value` entries are prose, not values:** 
"Validate required fields…" (~107), "Provide a fallback branch." (~113), 
"direct:cancel-order or direct:refund-credit" (~646). An AI agent will paste 
these in as literal option values. Keep `value` literal, or drop it and put the 
text in `reason`.
   > 4. `CamelCatalogTest` uses fully qualified `java.util.Collection` / 
`java.util.Set` / `java.util.HashSet`. CLAUDE.md asks for imports instead.
   > 5. Suggestions:
   >    
   >    * `route/dynamic-routing` is a `related` example for throttling rather 
than `direct`.
   >    * `normalizeCoverage` accepts synonyms ("exact", "building block") that 
the docs don't define. Asserting the three values strictly would be safer.
   >    * The validator runs with `new YamlValidator(false, …)`. Consider 
`true`, so non-canonical YAML is caught.
   >    * The recipe count and ids are hardcoded in several tests, so every new 
recipe means three edits.
   > 6. Nits:
   >    
   >    * `referenceDocs` point to `components/next/...` in a versioned catalog.
   >    * `idempotentRepository` is `processedOrderIds` in one place and 
`#processedOrderIds` in another.
   >    * The error-handling recipe lists `onException` in `eips` but doesn't 
use it.
   > 
   > _Claude Code on behalf of davsclaus. This review was generated by an AI 
agent and may contain inaccuracies; please verify all suggestions before 
applying._
   
   Thanks for the reviews. I've pushed the updates in commit `63e3f827aaaa` 
(`CAMEL-23774:Addressed Reviews`).
   
   The changes address the feedback as follows:
   
   - **Recipe accessibility:** Added `CamelCatalog.patternRecipesJSon()` and 
exposed the recipes through the shared Camel JBang authoring tool 
`camel_catalog_pattern_recipes`, including MCP integration. The recipes remain 
a higher-level pattern catalog; `camel_catalog_sample` continues to serve 
individual EIP/component YAML samples.
   - **File-polling example:** Added the missing `direct:process-invoice` 
consumer route.
   - **Structured recommendations:** Removed prose from 
`recommendedOptions.value` where there was no literal setting and moved the 
guidance into `reason`.
   - **Validation and tests:** Added the requested imports, switched to 
`assertFalse`, enabled canonical YAML validation, enforced the supported 
coverage values, and removed unnecessary hardcoded recipe counts and duplicated 
ID lists.
   - **Recipe metadata:** Corrected the throttling example coverage, versioned 
the component documentation links, made the idempotent repository references 
consistent, and removed `onException` from the error-handling recipe's EIP list.
   
   Regarding the catalog ownership question, I kept the recipes in 
`camel-catalog` so they are versioned alongside the component and EIP metadata 
they depend on. They describe complete integration patterns and operational 
guidance rather than replacing the existing individual EIP samples.
   
   **Validation:** The targeted Maven reactor build completed successfully, 
including `camel-catalog`, `camel-jbang-core`, `camel-jbang-mcp`, and 
`camel-yaml-dsl-validator` (10,886 goals, `BUILD SUCCESS`). `git diff --check` 
also passed.
   
   Please take another look at the updated commit. Thanks for the feedback.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to