saravanakumar1987 opened a new pull request, #30344:
URL: https://github.com/apache/camel/pull/30344

   # Description
   
   Fixes [CAMEL-27138](https://issues.apache.org/jira/browse/CAMEL-27138).
   
   ## Summary
   
   The Logstore name header of listLogStores, `CamelAlibabaSlsLogstoreName`, 
differed from `CamelAlibabaSlsLogStoreName` only in the case of one letter. 
Camel header names are case-insensitive by default, so the two names were one 
header. The Logstore name header of listLogStores is now 
`CamelAlibabaSlsListLogstoreName`, like `CamelAlibabaSlsListOffset` beside 
`CamelAlibabaSlsOffset`.
   
   - `AlibabaSlsProperties.LOGSTORE_NAME`, and so 
`AlibabaSlsHeaders.LOGSTORE_NAME`, now has the value 
`CamelAlibabaSlsListLogstoreName`.
   - The Endpoint DSL method `alibabaSlsLogstoreName()` is now 
`alibabaSlsListLogstoreName()`.
   - Routes that set the header or the exchange property by its literal name 
must use the new name.
   - The upgrade guide has a section on it.
   
   ### Why the constants keep their names
   
   The policy in `design/headers.adoc` keeps the Java constant names, so routes 
that use them need no change. It is a hard break with no alias for the old 
header name, as in the camel-rocketmq rename of 4.24. A class compiled against 
an earlier version keeps the old value until a new build, as Java inlines the 
constant.
   
   ## Tests
   
   - `LogstoreHeaderNamesTest` checks that a `CamelAlibabaSlsLogStoreName` 
header no longer sets the Logstore name of the listLogStores request.
   - It checks that a header set with `AlibabaSlsHeaders.LOGSTORE_NAME` no 
longer replaces the `logStoreName` option of getLogs.
   - It checks that listLogStores reads the header set with 
`AlibabaSlsHeaders.LOGSTORE_NAME`.
   - The first two tests failed before the change, and all 13 tests of the 
module pass now.
   
   # Target
   
   - [x] I checked that the commit is targeting the correct branch (Camel 4 
uses the `main` branch)
   
   # Tracking
   
   - [x] If this is a large change, bug fix, or code improvement, I checked 
there is a [JIRA issue](https://issues.apache.org/jira/browse/CAMEL) filed for 
the change (usually before you start working on it).
   
   # Apache Camel coding standards and style
   
   - [x] I checked that each commit in the pull request has a meaningful 
subject line and body.
   - [x] I ran `mvn clean install -Dquickly -DskipTests` in the root folder on 
the parent commit, 8fa7900132c8. Then I ran `mvn install -nsu` in the module, 
and `mvn install -DskipTests -nsu` in the catalog and Endpoint DSL.
   
   # AI-assisted contributions
   
   - [x] If this PR includes AI-generated code, commits have proper 
co-authorship attribution (e.g., `Co-authored-by` trailers) and the PR 
description identifies the AI tool used.
   
   Claude Code (Anthropic) drafted the change and this text, and ran the builds 
and tests named above. An independent AI review checked the change and this 
text.
   
   _Claude Code on behalf of saravanakumar1987_
   
   🤖 Generated with [Claude Code](https://claude.com/claude-code)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to