oscerd commented on PR #29831: URL: https://github.com/apache/camel/pull/29831#issuecomment-6942894336
Rebased on `main` (CAMEL-26837 and CAMEL-26839 landed last night) and pushed `CAMEL-26836: Route inputExpression through the reloading evaluator, remember an Error from the factory too, and say that create builds a non-reloading evaluator` (0c15129ec8bb): - **Hand-over with #29832**: `OpaReloadableWasmEvaluator` takes the `inputExpression` and passes it to its `OpaPolicyEvaluator` base, since its own `evaluate()` builds the input; `OpaEndpoint.createWasmEvaluator` and `OpaSecurityPolicy.buildEvaluator` pass `configuration.getInputExpression()` / the bean's `inputExpression` to `OpaReloadableWasmEvaluator.create`, and the inner `OpaWasmEvaluator` gets it as well. `OpaWasmIT.evaluatesTheCustomInputInsteadOfTheDefaultEnvelope` from #29832 passes against the rebased code, together with the rest of `OpaWasmIT` (real compiled WASM through the OPA container) and the unit tests. - **`catch (Throwable e)`** in `reload()` (the gnodet-bot thread and your point): an `Error` from the factory is remembered in `lastFailedRevision`, shown in the status and rethrown as it is; `anErrorFromTheFactoryIsRememberedLikeAnException` throws a `LinkageError` from the counting factory and checks the status and that the polls do not build that content again. - **Javadoc nit**: `OpaWasmEvaluator.create` now says it builds a non-reloading evaluator and that the producer and the policy build through `OpaReloadableWasmEvaluator.create`. - The doc section sits after the static-data section of #29835 under Evaluation modes; the generated metadata is regenerated on top of main, and the DSL factories follow from the CI regen step. _Claude Code on behalf of oscerd_ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
