davsclaus commented on issue #3144:
URL: 
https://github.com/apache/camel-kamelets/issues/3144#issuecomment-6929554664

   _Claude Code on behalf of Claus Ibsen_
   
   Documenting the 20 Kafka Kamelets in #3142 turned up several facts that 
support consolidating them:
   
   - **Names that do not match what the Kamelet does.** 
`kafka-apicurio-registry-not-secured-source` reads **JSON Schema** records, 
while `kafka-apicurio-registry-not-secured-sink` writes **Avro**. They look 
like a pair, but they are not.
   - **A missing variant.** There is no single-record Avro "not secured" 
Apicurio source at all.
   - **Inconsistent names.** `kafka-batch-apicurio-registry-source` does not 
say "not secured" in its name, although its Kafka connection is not secured.
   - **Inconsistent defaults.** `kafka-source` requires `saslAuthType` and has 
no default, while `kafka-batch-source` defaults to `NONE`.
   - **Kamelets that cannot start:**
     - **The three Azure schema registry Kamelets**: 
`kafka-azure-schema-registry-sink`, `kafka-azure-schema-registry-source` and 
`kafka-batch-azure-schema-registry-source`. The template uses 
`#bean:defaultAzureCredential`, but a template bean gets a unique name, so the 
lookup fails with `NoSuchBeanException`. It should be 
`#bean:{{defaultAzureCredential}}`.
     - **The Apicurio sources with a 
`mvn:io.quarkus:quarkus-apicurio-registry-*` dependency** (4 Kamelets). They 
fail on Camel JBang with "No available ApicurioHttClientProvider provider 
found". They may work only on Quarkus.
   - **The choice itself is the hard part for a user.** Most of the effort in 
#3142 went into making each summary and `Use it to` paragraph say which of the 
20 Kamelets to pick: plain, batch or manual commit; secured or not secured; 
Apicurio or Azure registry; JSON Schema or Avro.
   
   A few Kamelets whose security comes from options (`saslAuthType`, an 
optional registry with its own auth type) would remove most of these choices. 
The not-secured variants could be replaced by `saslAuthType: NONE`, as 
`kafka-source` and `kafka-sink` already do.
   
   #3142 documents the Kafka Kamelets as they are now, which is useful while 
they exist. Its descriptions also show which ones a consolidation would merge 
or drop.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to