Croway opened a new pull request, #30235:
URL: https://github.com/apache/camel/pull/30235

   JIRA: [CAMEL-27074](https://issues.apache.org/jira/browse/CAMEL-27074)
   
   - With `wrapped=false` (the default), the cxf producer in POJO mode invokes 
a document-literal wrapped operation with its parameters. A body that is the 
request wrapper object of the operation (such as `GreetMe` for `greetMe`) 
failed in CXF with `GreetMe cannot be cast to class java.lang.String`, or with 
"Get the wrong parameter size ... Expect size 2, Parameter size 1". Neither 
error named the operation or the `wrapped` option.
   - `CxfProducer.checkParameterSize` now fails such a body with an 
`IllegalArgumentException` that names the wrapper class, the operation, its 
parameter types and the `wrapped` option. It only fails when the object is an 
instance of the operation's request wrapper class and is not accepted as the 
parameter of the unwrapped operation, so calls that work today do not change.
   - The two "wrong parameter size" messages keep their first sentence and now 
name the operation and its parameter types.
   - With `wrapped=true` only the request is in wrapped form: the reply is 
still a `MessageContentsList` with the return value, not the response wrapper 
object. The `wrapped` option description and the POJO section of 
`cxf-component.adoc` now say so (component json, catalog copies and endpoint 
DSL regenerated).
   
   Tests: `CxfProducerWrapperObjectTest` (camel-cxf-soap). The 5 tests for the 
wrapper object (one, two and no parameters) and the parameter-size messages 
fail on main and pass with the fix. The 2 controls pass on both: parameters 
with `wrapped=false`, and the wrapper object with `wrapped=true`, where the 
reply is not wrapped. The camel-cxf-soap tests pass (204 run, 0 failures, 4 
skipped).
   
   No upgrade guide entry: only the error of a call that already failed changes.
   
   _Claude Code on behalf of Federico Mariani_
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to