davsclaus commented on code in PR #30212:
URL: https://github.com/apache/camel/pull/30212#discussion_r4588000196
##########
core/camel-core-model/src/main/java/org/apache/camel/model/dataformat/JaxbDataFormat.java:
##########
@@ -92,6 +92,12 @@ public class JaxbDataFormat extends DataFormatDefinition
implements ContentTypeH
@Metadata(label = "advanced", description = "XML namespace to use for
fragment parsing.")
private String partNamespace;
@XmlAttribute
+ @Metadata(label = "advanced", javaType = "java.lang.Boolean",
+ description = "Whether the CamelJaxbPartClass and
CamelJaxbPartNamespace headers are used, when set, instead of"
+ + " the partClass and partNamespace options when
marshalling and unmarshalling."
+ + " This should only be enabled when desired to be
used.")
Review Comment:
Done in 81a0e49b3467. The description now says when to enable it: "Enable it
only when the route sets these headers itself, not on routes that receive them
from external systems." The generated catalog, XSD and YAML DSL files carry the
same text.
_Claude Code on behalf of davsclaus_
##########
core/camel-core-model/src/main/java/org/apache/camel/model/dataformat/JaxbDataFormat.java:
##########
@@ -564,6 +581,26 @@ public Builder partNamespace(String partNamespace) {
return this;
}
+ /**
+ * Whether the CamelJaxbPartClass and CamelJaxbPartNamespace headers
are used, when set, instead of the
+ * partClass and partNamespace options when marshalling and
unmarshalling. This should only be enabled when
+ * desired to be used.
+ */
Review Comment:
Done in 81a0e49b3467, with the same text as the `@Metadata` description.
_Claude Code on behalf of davsclaus_
##########
core/camel-core-model/src/main/java/org/apache/camel/model/dataformat/JaxbDataFormat.java:
##########
@@ -564,6 +581,26 @@ public Builder partNamespace(String partNamespace) {
return this;
}
+ /**
+ * Whether the CamelJaxbPartClass and CamelJaxbPartNamespace headers
are used, when set, instead of the
+ * partClass and partNamespace options when marshalling and
unmarshalling. This should only be enabled when
+ * desired to be used.
+ */
+ public Builder allowPartClassFromHeader(String
allowPartClassFromHeader) {
+ this.allowPartClassFromHeader = allowPartClassFromHeader;
+ return this;
+ }
+
+ /**
+ * Whether the CamelJaxbPartClass and CamelJaxbPartNamespace headers
are used, when set, instead of the
+ * partClass and partNamespace options when marshalling and
unmarshalling. This should only be enabled when
+ * desired to be used.
+ */
Review Comment:
Done in 81a0e49b3467, with the same text as the `@Metadata` description.
_Claude Code on behalf of davsclaus_
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]