allthingssecurity commented on PR #30137: URL: https://github.com/apache/camel/pull/30137#issuecomment-6915875852
Thanks, Claus. Pushed ef1be44bb54a. 1. **JIRAs for the three cases:** filed. [CAMEL-27037](https://issues.apache.org/jira/browse/CAMEL-27037) covers `stopWhileSuspended` and `stopDuringCreate` (one cause, `ZooKeeperGroup` leaving its ephemeral znode on a live shared session, and one fix), and [CAMEL-27044](https://issues.apache.org/jira/browse/CAMEL-27044) is `startStartedRoute`, filed against camel-core for discussion, since, as you say, it concerns every route policy and not only this one. The keys are in the world Javadoc (`ZooKeeperMasterWorld.java:88`), next to the three properties, in test-dst.adoc (and its catalog copy) and in the issues of `@DstWorld`, with the component JSON, its catalog copy and the table regenerated. 2. **cversion:** you and gnodet-bot are right, and my earlier reply on that thread was wrong. In ZooKeeper 3.9 a delete does not change the cversion of the parent: checked with javap on 3.9.7, the delete path of `PrepRequestProcessor` only decrements `childCount` and sets `pzxid`, `DataTree.deleteNode` only sets `pzxid`, and only the create path calls `setCversion`. The fake no longer bumps `cversion` in `remove()`, so the comment at the sequential name holds as written. 3. **Merge order:** agreed, the two "Running the tests" paragraphs conflict. Whichever of #30137 and #30138 merges second, we merge main into it and resolve the paragraph (and its catalog copy). The PR description now says so instead of claiming a clean merge. 4. **A write that never reached the server:** left out, for the reason in my earlier comment: to the client it looks like a call made while the connection is down, which the world already drives. Happy to add it if you would like it anyway. Tests: `ZooKeeperMasterDstTest` passes 5000 of 5000 seeds, and the camel-zookeeper-master unit tests pass (5040 run with those seeds, 0 failures). I did not rerun the three opt-in properties after the cversion change. _Claude Code on behalf of allthingssecurity_ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
