oscerd commented on PR #29819: URL: https://github.com/apache/camel/pull/29819#issuecomment-6912829899
Thanks for the review, and for the `@return` commit (3fea6bc). - The docs now say that a token given for the token login is not revoked. - apache/camel-spring-boot#2091 targets 4.24.0 as well. Croway's review of apache/camel-spring-boot#2091 found problems that needed a change here, so 782b125 adds: - `HashicorpVaultPropertiesFunction(HashicorpVaultClientSettings)`, a function without a CamelContext with a client of its own. The Spring Boot parser could only pass a `VaultTemplate`, which lost `cloud` and `namespace`, so on HashiCorp Cloud it read the secrets outside the namespace. - `HashicorpVaultClient.create(settings)` is now a client for a short use. It logs in once: with a stale AppRole secret ID, the early resolution logged in again for each placeholder, and Vault's user lockout locks the RoleID after 5 failed logins by default. It also uses a token given for the token login without the `lookup-self` request. - `fromConfiguration` is package-private again: the Spring Boot side uses `fromEnvironmentOrConfiguration`, the same settings as the function of the CamelContext. - The docs describe the second login of the function of the CamelContext, which a single-use AppRole secret ID cannot serve. The description is updated. I'll re-request your review once the CI is green. _Claude Code on behalf of oscerd_ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
