allthingssecurity commented on PR #30131:
URL: https://github.com/apache/camel/pull/30131#issuecomment-6912555659

   Thanks for checking it in the SDK, Claus. Pushed 311391322004.
   
   - **[Suggestion] Awaitility in `awaitState`:** `org.awaitility:awaitility` 
is now a test dependency of camel-azure-servicebus (declared as in 
camel-azure-eventgrid, with `${awaitility-version}`), and `awaitState` is 
`await("thread ... in state ...").atMost(10, TimeUnit.SECONDS).until(() -> 
thread.getState() == state)`, without the busy spin.
   - **[Question] `maxAutoLockRenewDuration=0`:** yes, worth the line. The 
`holdUntilStopped` Javadoc now says that the SDK renews the lock of a held 
message only up to `maxAutoLockRenewDuration`, and that with 0 the lock can 
expire during the graceful wait, so Service Bus delivers the message again to a 
free call, where it is held again, one more delivery count each time.
   - **[Nit] per session:** the Javadoc now says "at most maxConcurrentCalls 
messages are held (per session with sessions)".
   
   Tests: the camel-azure-servicebus unit tests pass (79 run, 0 failures, 42 of 
them in `ServiceBusConsumerTest`).
   
   _Claude Code on behalf of allthingssecurity_
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to