oscerd commented on PR #29822:
URL: https://github.com/apache/camel/pull/29822#issuecomment-6912509412

   Rebased on `main` (CAMEL-26831 moved JWT validation; the generated 
`spiffe.json` was regenerated) and pushed `CAMEL-26834: fetchJwtSvid mints the 
token for the configured local identity, and both fetches clear the identity 
headers first` (27915f93841a):
   
   - **Must fix**: `fetchJwtSvid` now calls 
`WorkloadApiClient.fetchJwtSvid(SpiffeId subject, String audience, String... 
extra)` when `localSpiffeId` is set, so the token is minted for that identity 
and SPIRE refuses a subject the workload is not entitled to; `validateJwtSvid` 
still ignores the option, as there is no local identity to choose. The option's 
description and the doc section say so (the "two JWT operations do not use it" 
sentence is gone). 
`SpiffeProducerTest.fetchJwtSvidMintsTheTokenForTheConfiguredLocalIdentity` 
covers it and checks the default overload is never asked.
   - Both fetch operations clear `CamelSpiffeSpiffeId` and `CamelSpiffeExpiry` 
before fetching, with or without a configured identity, so a failed fetch 
leaves no stale identity behind.
   - Generated JSON, URI factory and the catalog copies regenerated; the 
component and endpoint DSL factories follow from the CI regen step, since those 
generators need the whole reactor to run locally.
   
   Unit tests green locally. #29821 adds a readiness check that watches the 
default SVID; the second of the two to merge makes the check follow the same 
selector.
   
   _Claude Code on behalf of oscerd_
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to