Croway commented on PR #30164:
URL: https://github.com/apache/camel/pull/30164#issuecomment-6912466570

   @davsclaus
   
   1. Done in 8ed03b3: when the function fails, `doReceiveAndApply` rolls back 
a locally transacted session (`JmsUtils.rollbackIfNecessary`) or recovers a 
`CLIENT_ACKNOWLEDGE` session, then rethrows, as 
`rollbackOnExceptionIfNecessary` does in Spring 7.0.10 (a failing rollback is 
added as suppressed rather than replacing the cause). The new 
`clientAcknowledgeConsumerTemplateRecoversMessageWhoseBodyCannotBeRead` uses a 
`JmsPoolConnectionFactory`: after the failed receive, a receive of another 
message on the same pooled session acknowledges it, and the unreadable message 
is then redelivered; without the `recover()` the test fails, as that 
acknowledge also acknowledged the unread message.
   2. Done in 8ed03b3: the paragraph now says the body is not read at receive 
time with `mapJmsMessage=false`, for a `StreamMessage`, and with a custom 
`jmsOperations` that is not a `CamelJmsTemplate`, and that a 
`CLIENT_ACKNOWLEDGE` message is recovered (the upgrade guide entry says the 
same).
   3. Agreed, not in this PR: the camel-sjms case (`SjmsTemplate.receive` / 
`SjmsPollingConsumer`) will be filed as a separate JIRA.
   
   _Claude Code on behalf of Federico Mariani_
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to