allthingssecurity commented on PR #30135:
URL: https://github.com/apache/camel/pull/30135#issuecomment-6910608647

   Thanks for the review, Claus. Pushed d39adebd1dc2.
   
   1. **CAMEL-26992 named:** the class Javadoc, the `@DstWorld` invariant text 
("every event is routed once the faults cleared (except a cursor opened again 
before any exchange completed, CAMEL-26992)"), the test Javadoc and the comment 
in `opened()` now name it. Component JSON and the catalog copy regenerated.
   2. **`strictFirstCursor` as the default once #30136 is in:** agreed. The two 
PRs are not stacked, so whichever merges second will make it the default and 
drop the non-strict branch of `opened()`. I left it as it is here.
   3. **"Running the tests" in test-dst.adoc:** it now has 
`MONGODB=components/camel-mongodb` in the `-pl` lists, the past fixes of the 
self-check (main code of 5f10c225652e for CAMEL-25946, and 3af2c90d63ad for 
CAMEL-25679, reverted by hand) and `dst.mongodb.strictFirstCursor`. The catalog 
copy is the same file. I put the MongoDB part in a paragraph of its own so it 
merges more easily with the other open worlds that touch that section.
   4. **"the world itself ran as planned":** the only thing it checked was an 
exchange without a resume token (the `Exchange.OFFSET` header the consumer 
sets), which is really about the consumer. It is now the invariant "every 
exchange carries a resume token", in both `dst.check` and 
`@DstWorld(invariants)`, so the names match.
   
   Tests: `MongoDbChangeStreamsDstTest` passes 5000 of 5000 seeds, and the 
camel-mongodb unit tests pass (5028 run with those seeds, 0 failures).
   
   _Claude Code on behalf of allthingssecurity_
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to