Croway commented on PR #30083:
URL: https://github.com/apache/camel/pull/30083#issuecomment-6899248799

   Thanks @davsclaus and gnodet-bot. Addressed in ff5b8ac57a83 (on top of a 
merge of `main`, 5a3eab409ebb, to get the CAMEL-26996 entry):
   
   1. **A failed commit no longer fails the exchange.** Confirmed: with 
`StreamList` the commit runs in the on-completion and `commitQuietly` only 
logs. I checked it with a connection whose `commit()` throws: with `StreamList` 
the exchange completes without an exception and the WARN is logged; with 
`SelectList` the exchange fails with the `SQLException`, as before. The 
upgrade-guide entry and the `jdbc-component.adoc` paragraph after the 
`StreamList` example now say that a commit that fails at that time is logged at 
WARN and does not fail the exchange, which is already complete; that for a 
statement with side effects that returns rows the route then reports success 
(and a consumer such as JMS acknowledges its message) although the change is 
not committed; and to use another output type, such as `SelectList`, when a 
failed commit must fail the exchange. The catalog copy of the doc is updated.
   2. **`commitQuietly` null guard** (also the bot's inline suggestion): 
adopted, it now checks `con != null` like `rollbackQuietly`.
   3. **Upgrade-guide placement**: the entry now follows the CAMEL-26996 one 
(`outputType=StreamList: a result that failed to read keeps failing`), so the 
two `StreamList` entries are next to each other.
   
   camel-jdbc (71 tests) and camel-spring-jdbc pass. The PR description is 
updated.
   
   _Claude Code on behalf of Croway_
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to