Dhairya-007 opened a new pull request, #30085:
URL: https://github.com/apache/camel/pull/30085
## Problem
All 12 of the component's model-class header `javaType` values name the
class by simple name only:
```java
@Metadata(description = "The messages of the conversation.", javaType =
"List<Message>")
public static final String CONVERSE_MESSAGES =
"CamelAwsBedrockConverseMessages";
```
```json
"CamelAwsBedrockConverseMessages": { ..., "javaType": "List<Message>", ... }
```
Fully qualified is the convention by a wide margin - across the whole
catalog, 3692 header `javaType` values are fully qualified or a built-in type,
and 151 are not.
`Message` is the one that most needs saying out loud: in a Camel component,
a header documented as `List<Message>` reads as Camel's own
`org.apache.camel.Message`, which is what `Message` resolves to in most of this
codebase. Here it is
`software.amazon.awssdk.services.bedrockruntime.model.Message`, and both names
are imported in this very module - `AWS2BedrockConstants`' neighbours use the
Camel one. A reader building a conversation from the catalog alone has no way
to tell which, and the two are not interchangeable.
The rest are Bedrock runtime model classes with no Camel counterpart, but
the same reasoning applies: all 12 resolve to
`software.amazon.awssdk.services.bedrockruntime.model`.
## Fix
Qualify all 12. The `List` spelling is left as it is, matching the rest of
the catalog; only the model classes are qualified. Header names are untouched.
Metadata only - no behaviour change. I diffed the regenerated catalog file
against `main` and confirmed the 12 `javaType` values are the only fields that
differ.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]