Dhairya-007 opened a new pull request, #30084:
URL: https://github.com/apache/camel/pull/30084

   ## Problem
   
   All 9 of the component's model-class header `javaType` values name the class 
by simple name only:
   
   ```java
   @Metadata(label = "producer", description = "The findings to import.", 
javaType = "List<AwsSecurityFinding>")
   public static final String FINDINGS = "CamelAwsSecurityHubFindings";
   ```
   
   ```json
   "CamelAwsSecurityHubFindings": { ..., "javaType": 
"List<AwsSecurityFinding>", ... }
   ```
   
   Fully qualified is the convention by a wide margin - across the whole 
catalog, 3692 header `javaType` values are fully qualified or a built-in type, 
and 151 are not.
   
   These nine are the component's producer contract: every operation takes or 
returns one of them, and all nine come from 
`software.amazon.awssdk.services.securityhub.model`. `NoteUpdate`, 
`SeverityUpdate` and `WorkflowUpdate` are especially worth qualifying - the 
Security Hub SDK also has `Note`, `Severity` and `Workflow`, so three 
near-identical pairs of simple names sit in the same package, and the 
`...Update` form is the one these headers take.
   
   ## Fix
   
   Qualify all 9 to `software.amazon.awssdk.services.securityhub.model.*`. The 
`List` spelling is left as it is, matching the rest of the catalog; only the 
model classes are qualified. Header names are untouched.
   
   Metadata only - no behaviour change. I diffed the regenerated catalog file 
against `main` and confirmed the 9 `javaType` values are the only fields that 
differ.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to