davsclaus opened a new pull request, #30070:
URL: https://github.com/apache/camel/pull/30070

   JIRA: [CAMEL-27002](https://issues.apache.org/jira/browse/CAMEL-27002). 
Related: CAMEL-21521 (remove bind command), CAMEL-23152 (bind deprecated in 
4.19), CAMEL-24807 (Pipe in the YAML DSL deprecated in 4.23).
   
   Camel works with routes as its abstraction. Pipes and Integrations are Camel 
K resources; a route does the same and more. This removes their support (45 
files, about 5,000 lines).
   
   ## Removed
   
   - **camel-yaml-dsl:** `YamlRoutesBuilderLoader` no longer loads `kind: Pipe` 
(or `KameletBinding`) resources with `apiVersion: camel.apache.org/v1`. That 
was about 290 lines: `preConfigurePipe`, the source, steps, sink and error 
handler mapping, and the Strimzi and Knative endpoint mapping that only Pipes 
used. `pipe.yaml` is no longer a file extension of the YAML DSL. 
`PipeLoaderTest` and `PipeLoaderErrorHandlerTest` are removed.
   - **camel-jbang:**
     - the `camel bind` command (the `bind` package: the command, its 6 binding 
providers and its template; 5 test classes);
     - `camel init --pipe` and its template, and the Integration CR template of 
`camel init`, from the templates and the interactive picker;
     - `camel run` accepting a YAML file that contains `Pipe` (`RunFiles`);
     - Pipe and Integration resources in the routes the AI tools read 
(`ProjectRoutes`);
     - `bind` from the "Actions" help group;
     - the tests: `ExportTest.shouldExportPipeOfficialAndCustomKamelet`, 
`InitTest.initPipe`, three `TemplateHelperTest` methods, 
`RunCommandITCase.runCamelKCRDTest` (with `joke.yaml`), and 
`KameletMainManualTest.testReloadCamelK` (with `my-camel-k.yaml`).
   - **camel-yaml-dsl-validator:** `EndpointConsumers` now reads a Pipe or an 
Integration as a YAML file without routes. It used to treat a Pipe as consuming 
anything unknown, and read the flows of an Integration.
   - **Docs:**
     - the `camel bind` page and its line in the commands index;
     - the Pipe section of `yaml-dsl.adoc` (and its catalog copy);
     - `--pipe` is gone from the `camel init` page;
     - the golden help and parse files, without `bind` and `init --pipe`.
   
   Upgrade guide: a 4.24 entry "Camel K Pipe and Integration resources are 
removed (camel bind)". It says what to write instead and links to the 4.23 
entry that shows a Pipe next to the route that does the same.
   
   Kamelets are not affected: routes keep using `kamelet:` endpoints.
   
   ## camel-kamelets
   
   I checked apache/camel-kamelets for tests that need Pipes:
   - The 74 active tests (`*.citrus.it.yaml`) all run plain route files with 
`camel jbang run`, including the ones named `*-uri-pipe`.
   - Only 3 Cucumber `.feature` files load Pipes. They run on Camel K, where 
the operator turns the Pipe into an integration, and nothing runs them (no 
Cucumber runner).
   - The Kamelet docs pages still show Camel K Pipe examples, from 
`templates/pipes/camel-k`, next to the route examples in 
`templates/pipes/core`. That repository can drop them separately, and should, 
if camel-kamelets moves into Camel (CAMEL-21049).
   
   ## Tests
   
   Green:
   - camel-yaml-dsl (495);
   - camel-yaml-dsl-validator (369, with `testACamelKResourceIsNotARouteFile`);
   - camel-kamelet-main, camel-jbang-run (341);
   - camel-jbang-core (3070, with the updated golden files);
   - camel-jbang-plugin-tui (2617);
   - camel-jbang-it compiles.
   
   _Claude Code on behalf of davsclaus_
   
   🤖 Generated with [Claude Code](https://claude.com/claude-code)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to