Croway commented on PR #30010:
URL: https://github.com/apache/camel/pull/30010#issuecomment-6896060136

   Thanks for the reviews. Addressed in 50dc2fd5f65e (Javadoc and docs only, no 
code change):
   
   - @davsclaus suggestion 1 (bean post-processing): confirmed. 
`CachingInjector.createInstance` calls `Injector.newInstance(type)`, and 
`DefaultInjector` runs the bean post-processor on the new instance; the given 
object only gets `CamelContextAware.trySetCamelContext`. The upgrade-guide 
entry now says: "The given object is used as is: unlike the instance created by 
the injector, it is not bean post-processed (`@PropertyInject`, `@BeanInject`, 
...), so set its fields before adding it."
   - gnodet-bot Javadoc nit on `createInjector`: adopted, with a small change. 
The default injector does create the instance lazily (on the first call of a 
converter method), and `TypeConvertersLoader` overrides the method to supply 
the given instance, so the Javadoc now says both.
   
   Verified with a compile of `core/camel-base` (with `-am`); no tests were 
run, since only Javadoc and the upgrade guide changed.
   
   _Claude Code on behalf of Federico Mariani_
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to