gnodet-bot commented on code in PR #30009:
URL: https://github.com/apache/camel/pull/30009#discussion_r4578155286
##########
components/camel-quartz/src/main/docs/quartz-component.adoc:
##########
@@ -56,10 +56,12 @@ Each endpoint represents a different timer (in Quartz
terms, a `Trigger` and ``J
=== Configuring quartz.properties file
-By default, Quartz will look for a `quartz.properties` file in the
-`org/quartz` directory of the classpath. If you are using WAR
-deployments, this means just drop the quartz.properties in
-`WEB-INF/classes/org/quartz`.
+By default, the Camel Quartz component loads the `quartz.properties` file
+from the `org/quartz` directory of the classpath, which is the default file in
the Quartz JAR.
+Unlike Quartz itself, it does not read a `quartz.properties` file at the root
of the classpath,
+or the file set by the `org.quartz.properties` system property, and it logs a
WARN when it finds one.
Review Comment:
📝 **Minor doc inaccuracy:** "it logs a WARN when it **finds** one" is
slightly imprecise. For the system-property branch, the WARN fires when the
property is **set** (regardless of whether the referenced file actually
exists), not when a file is found. Only the classpath-root branch actually
checks for file presence.
Consider: `...and it logs a WARN when it encounters one` or simply describe
both cases: `and it logs a WARN — when the system property is set, or when a
\`quartz.properties\` is found at the classpath root`.
##########
components/camel-quartz/src/main/java/org/apache/camel/component/quartz/QuartzComponent.java:
##########
@@ -298,6 +299,24 @@ private SchedulerFactory createSchedulerFactory() throws
SchedulerException {
return answer;
}
+ /**
+ * Quartz itself first reads the file named by the org.quartz.properties
system property, then a quartz.properties
+ * at the root of the classpath, but Camel uses only
org/quartz/quartz.properties unless an option is set.
+ */
Review Comment:
📝 **Nit:** The Javadoc describes what Quartz does but doesn't document what
*this* method does. Suggest flipping the focus:
```suggestion
/**
* Warns if a {@code quartz.properties} file at the root of the
classpath or the file set by the
* {@code org.quartz.properties} system property would be ignored, since
Camel uses only
* {@code org/quartz/quartz.properties} unless {@code propertiesFile}
(or similar options) is set.
*/
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]