Dhairya-007 commented on PR #29956:
URL: https://github.com/apache/camel/pull/29956#issuecomment-6892540327

   Both done, thanks.
   
   1. Added a `=== camel-thymeleaf` section to 
`camel-4x-upgrade-guide-4_24.adoc`, with the `WebApplicationTemplateResolver` 
line that shows what the resolver is really built from, and the 
`setJakartaServletWebApplication(JakartaServletWebApplication.buildApplication(servletContext))`
 call the component's own `ThymeleafWebApplicationResolverTest` uses.
   2. Good point — it is a plain field on `ThymeleafEndpoint`, with no 
`@UriParam`, so "set on the endpoint" was ambiguous. The note now reads "... 
built from the JakartaServletWebApplication given to 
ThymeleafEndpoint.setJakartaServletWebApplication, which is not a URI option", 
and I regenerated the two `thymeleaf.json` files and the header javadoc in 
`ThymeleafEndpointBuilderFactory`.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to