Dhairya-007 commented on PR #29972:
URL: https://github.com/apache/camel/pull/29972#issuecomment-6892466095

   All four done, thanks.
   
   1. Confirmed the history: `PdfProducer` read the header and called 
`PDDocument.openProtection(decryptionMaterial)` until CAMEL-11976 
(`a3e01676d59a`, Nov 2017) aligned the component on PDFBox 2.0.6 and removed 
both reads. That lands in 2.21, so "no longer read" / "no effect since Camel 
2.21" it is — "never" was wrong.
   2. Applied gnodet-bot's suggestion with your wording change. The description 
is now one sentence, "No longer read by the component (no effect since Camel 
2.21).", and the reason sits only in `deprecationNote`, so the catalog no 
longer repeats it — and "Deprecated.*" is gone with the paragraph that produced 
it.
   3. Added a `=== camel-pdf` section to `camel-4x-upgrade-guide-4_24.adoc` 
with the `Processor` that calls `Loader.loadPDF(bytes, password)`, and a note 
that the component's `byte[]` converter loads without a password.
   4. `PdfAppendTest` and `PdfTextExtractionTest` no longer set the header; 
`PdfTextExtractionTest` now uses `sendBody` and both lost the 
`StandardDecryptionMaterial` import. Both tests still load their encrypted 
document with `userPass`, which is what actually decrypts it, so the coverage 
is unchanged.
   
   Regenerated the two `pdf.json` files and the header javadoc in 
`PdfEndpointBuilderFactory`.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to