gnodet-bot commented on code in PR #29912:
URL: https://github.com/apache/camel/pull/29912#discussion_r4572902457


##########
dsl/camel-jbang/camel-jbang-core/src/main/java/org/apache/camel/dsl/jbang/core/commands/ai/AuthoringTools.java:
##########
@@ -242,12 +243,15 @@ static void register(Consumer<ToolDescriptor> registry) {
                                                 + "from; with file (a path 
relative to the directory, as listed) its content.")
                 .param("directory", "string", DIRECTORY_DESC, false)
                 .param("file", "string", FILE_PATH_DESC + " to read; omitted 
lists the files", false)
+                .param("offset", "string", "The first line to read, from 1 
(default 1)", false)

Review Comment:
   🔍 **Schema type mismatch:** `offset` and `limit` are declared as `"string"` 
in the registry descriptor, but they are integers. Other `limit` params in this 
same file use `"integer"`. The registry JSON schema (used by `camel ask` and 
other clients) will advertise `{"type": "string"}` instead of `{"type": 
"integer"}`.
   
   ```suggestion
                   .param("offset", "integer", "The first line to read, from 1 
(default 1)", false)
                   .param("limit", "integer", "How many lines to read (default 
" + READ_LINES + ")", false)
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to