Update CMISSessionFacade.java Hi, this piece of code causes two calls in a row for content stream. Result of document.getContentStream() has to be stored and used where is needed, not to call document.getContentStream() in condition and than again in return statement.
Project: http://git-wip-us.apache.org/repos/asf/camel/repo Commit: http://git-wip-us.apache.org/repos/asf/camel/commit/1fbb5b85 Tree: http://git-wip-us.apache.org/repos/asf/camel/tree/1fbb5b85 Diff: http://git-wip-us.apache.org/repos/asf/camel/diff/1fbb5b85 Branch: refs/heads/master Commit: 1fbb5b85b0669c5ac6c17c2e74be68e37a1daf9c Parents: 6c1c816 Author: Tomáš Burian <tomas.bur...@lundegaard.eu> Authored: Wed May 31 15:06:01 2017 +0200 Committer: Claus Ibsen <davscl...@apache.org> Committed: Thu Jun 1 09:09:41 2017 +0200 ---------------------------------------------------------------------- .../java/org/apache/camel/component/cmis/CMISSessionFacade.java | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/camel/blob/1fbb5b85/components/camel-cmis/src/main/java/org/apache/camel/component/cmis/CMISSessionFacade.java ---------------------------------------------------------------------- diff --git a/components/camel-cmis/src/main/java/org/apache/camel/component/cmis/CMISSessionFacade.java b/components/camel-cmis/src/main/java/org/apache/camel/component/cmis/CMISSessionFacade.java index 7b47e69..d143d7c 100644 --- a/components/camel-cmis/src/main/java/org/apache/camel/component/cmis/CMISSessionFacade.java +++ b/components/camel-cmis/src/main/java/org/apache/camel/component/cmis/CMISSessionFacade.java @@ -182,8 +182,9 @@ public class CMISSessionFacade { public InputStream getContentStreamFor(QueryResult item) { Document document = getDocument(item); - if (document != null && document.getContentStream() != null) { - return document.getContentStream().getStream(); + ContentStream contentStream = document.getContentStream(); + if (document != null && contentStream != null) { + return contentStream.getStream(); } return null; }
