davsclaus commented on PR #29428:
URL: https://github.com/apache/camel/pull/29428#issuecomment-6738386011
@ammachado the rest of your first review is addressed in 33edc54e72fe:
3. **An exact build chosen through `self-update` is now kept:** `camel
self-update --version X.Y.Z-YYYYMMDD.HHMMSS-N` writes a NIGHTLY pin. A plain
`camel self-update` on that pin is refused, and the message names `--version
X.Y.Z-SNAPSHOT` / `--version SNAPSHOT` to follow the nightly builds again, or
`--version LTS` to go back to the releases. An explicit `--version` switches it
(see the reply to Croway's third point). Tests: `oneNightlyBuildIsPinned`,
`nightlyBuildPinRefusesAPlainSelfUpdate` and
`nightlyBuildPinSwitchesToTheNightlyBuildsOfMain`.
4. **`nightly` is initialized** at the top of `install_nightly`. Test:
`WebsiteInstallTest.nightlyFromTheEnvironmentIsIgnored` exports `nightly=<an
older build>` and checks that the newest build from the metadata is installed.
5. **Test gaps:**
- LTS/X.Y pin with `--version SNAPSHOT`: this now switches instead of
being refused (`ltsPinSwitchesToTheNightlyBuildsOfMain`), and `--version X.Y.Z`
on such a pin stays refused (existing `selectorPinRefusesExplicitVersion`).
- NIGHTLY pin refusing a plain `self-update`:
`nightlyBuildPinRefusesAPlainSelfUpdate`.
- Leaving a SNAPSHOT pin when the release install fails:
`failedReleaseInstallKeepsTheSnapshotPin`.
- Explicit selector when already on the newest build:
`explicitSnapshotVersionOnItsNewestBuildStillWritesThePin`.
- Running build of another snapshot version:
`snapshotPinMovesFromAnotherSnapshotVersionToMain`.
- `prune_nightlies` with two versions, and the `keep_build` guard:
`keepsTheNewestThreeNightliesAcrossSnapshotVersions` and
`keepsAnOlderNightlyJustInstalled`.
- `UpdateChecker` quiet for nightly pins: the decision moved into
`notifiesFor(Pin)`, and
`notifiesUnpinnedAndSelectorPinsButNeitherExactNorNightlyPins` tests it.
**Minor:**
- The `ManifestFetcher` constructor comment is corrected.
- The build pattern exists once now, as `InstallDetector.NIGHTLY_BUILD` with
groups, and `Nightly` uses it.
- The nightly tests in `WebsiteInstallTest` use JUnit assertions only (the
module mostly uses JUnit).
- The dev@ question is still open; I'll leave that one to Claus.
The full camel-launcher suite passes locally: 407 tests, 0 failures.
_Claude Code on behalf of davsclaus_
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
