Dhairya-007 opened a new pull request, #29487:
URL: https://github.com/apache/camel/pull/29487
Two `camel-minio` option descriptions were copied from `camel-aws2-s3` and
kept that component's option names. The two components spell these options
differently:
| | camel-minio declares | camel-aws2-s3 declares |
| --- | --- | --- |
| auto-close | `autoCloseBody` | `autocloseBody` |
| move target | `destinationBucketName` | `destinationBucket` |
So minio's docs name options that minio does not have, and Camel fails fast
on unknown URI parameters.
**`includeBody` and `autoCloseBody`** both say:
> This option is strongly related to **autocloseBody** option. In case of
setting includeBody to true and **autocloseBody** to false, it will be up to
the caller to close the MinioObject stream. Setting **autocloseBody** to true,
will close the MinioObject stream automatically.
**`moveAfterRead`** says:
> To accomplish the operation the **destinationBucket** option must be set.
`minio-component.adoc` repeats that one in prose, while the Java and XML
examples immediately below it already use the right name:
```java
from("minio://mycamelbucket?minioClient=#minioClient&moveAfterRead=true&destinationBucketName=myothercamelbucket")
```
`camel-aws2-s3` really does declare `autocloseBody` and `destinationBucket`,
so its descriptions, its tests and `docs/user-manual/.../large-payloads.adoc`
are correct as they stand and are left untouched.
Generated metadata, the catalog copies and the endpoint DSL javadoc are
updated to match. The DSL javadoc is machine-wrapped, so I reproduced
`EndpointDslMojo.formatJavadocOrCommentStringAsList` (wrap at `78 - indent`)
and verified it regenerates the current text byte-for-byte before applying the
change.
Documentation only — no behaviour change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
