CAMEL-11353: Optimise - small
Project: http://git-wip-us.apache.org/repos/asf/camel/repo Commit: http://git-wip-us.apache.org/repos/asf/camel/commit/4a3debee Tree: http://git-wip-us.apache.org/repos/asf/camel/tree/4a3debee Diff: http://git-wip-us.apache.org/repos/asf/camel/diff/4a3debee Branch: refs/heads/master Commit: 4a3debee1d8944cf8ad693cafb7e7137593bcc88 Parents: 8bf8cd1 Author: Claus Ibsen <davscl...@apache.org> Authored: Sun May 28 19:20:08 2017 +0200 Committer: Claus Ibsen <davscl...@apache.org> Committed: Sun May 28 19:20:08 2017 +0200 ---------------------------------------------------------------------- .../camel/management/mbean/ManagedCounter.java | 20 ++++++++------------ .../mbean/ManagedPerformanceCounter.java | 8 ++++---- 2 files changed, 12 insertions(+), 16 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/camel/blob/4a3debee/camel-core/src/main/java/org/apache/camel/management/mbean/ManagedCounter.java ---------------------------------------------------------------------- diff --git a/camel-core/src/main/java/org/apache/camel/management/mbean/ManagedCounter.java b/camel-core/src/main/java/org/apache/camel/management/mbean/ManagedCounter.java index 5605ae2..562c951 100644 --- a/camel-core/src/main/java/org/apache/camel/management/mbean/ManagedCounter.java +++ b/camel-core/src/main/java/org/apache/camel/management/mbean/ManagedCounter.java @@ -25,31 +25,27 @@ import org.apache.camel.spi.ManagementStrategy; @ManagedResource(description = "Managed Counter") public abstract class ManagedCounter implements ManagedCounterMBean { protected Statistic exchangesTotal; - protected Statistic startTimestamp; - protected Statistic resetTimestamp; + protected Date startTimestamp; + protected Date resetTimestamp; public void init(ManagementStrategy strategy) { this.exchangesTotal = new StatisticCounter(); - this.startTimestamp = new StatisticValue(); - this.resetTimestamp = new StatisticValue(); - long now = new Date().getTime(); - startTimestamp.updateValue(now); - resetTimestamp.updateValue(now); + Date now = new Date(); + startTimestamp = now; + resetTimestamp = now; } public void reset() { exchangesTotal.reset(); - resetTimestamp.updateValue(new Date().getTime()); + resetTimestamp = new Date(); } public Date getStartTimestamp() { - long value = startTimestamp.getValue(); - return value > 0 ? new Date(value) : null; + return startTimestamp; } public Date getResetTimestamp() { - long value = resetTimestamp.getValue(); - return value > 0 ? new Date(value) : null; + return resetTimestamp; } public long getExchangesTotal() throws Exception { http://git-wip-us.apache.org/repos/asf/camel/blob/4a3debee/camel-core/src/main/java/org/apache/camel/management/mbean/ManagedPerformanceCounter.java ---------------------------------------------------------------------- diff --git a/camel-core/src/main/java/org/apache/camel/management/mbean/ManagedPerformanceCounter.java b/camel-core/src/main/java/org/apache/camel/management/mbean/ManagedPerformanceCounter.java index d12e6eb..b234a64 100644 --- a/camel-core/src/main/java/org/apache/camel/management/mbean/ManagedPerformanceCounter.java +++ b/camel-core/src/main/java/org/apache/camel/management/mbean/ManagedPerformanceCounter.java @@ -216,7 +216,7 @@ public abstract class ManagedPerformanceCounter extends ManagedCounter implement lastProcessingTime.updateValue(time); deltaProcessingTime.updateValue(time); - long now = new Date().getTime(); + long now = System.currentTimeMillis(); if (!firstExchangeCompletedTimestamp.isUpdated()) { firstExchangeCompletedTimestamp.updateValue(now); } @@ -249,7 +249,7 @@ public abstract class ManagedPerformanceCounter extends ManagedCounter implement externalRedeliveries.increment(); } - long now = new Date().getTime(); + long now = System.currentTimeMillis(); if (!firstExchangeFailureTimestamp.isUpdated()) { firstExchangeFailureTimestamp.updateValue(now); } @@ -277,8 +277,8 @@ public abstract class ManagedPerformanceCounter extends ManagedCounter implement sb.append(String.format(" meanProcessingTime=\"%s\"", meanProcessingTime.getValue())); if (fullStats) { - sb.append(String.format(" startTimestamp=\"%s\"", dateAsString(startTimestamp.getValue()))); - sb.append(String.format(" resetTimestamp=\"%s\"", dateAsString(resetTimestamp.getValue()))); + sb.append(String.format(" startTimestamp=\"%s\"", dateAsString(startTimestamp.getTime()))); + sb.append(String.format(" resetTimestamp=\"%s\"", dateAsString(resetTimestamp.getTime()))); sb.append(String.format(" firstExchangeCompletedTimestamp=\"%s\"", dateAsString(firstExchangeCompletedTimestamp.getValue()))); sb.append(String.format(" firstExchangeCompletedExchangeId=\"%s\"", nullSafe(firstExchangeCompletedExchangeId))); sb.append(String.format(" firstExchangeFailureTimestamp=\"%s\"", dateAsString(firstExchangeFailureTimestamp.getValue())));
