gnodet-bot commented on code in PR #29470:
URL: https://github.com/apache/camel/pull/29470#discussion_r4512370965
##########
core/camel-util/src/main/java/org/apache/camel/util/ArtifactUtils.java:
##########
@@ -50,11 +50,9 @@ Map.<String, String> entry("alibaba-sms",
"camel-alibaba-sms"),
Map.<String, String> entry("amqp", "camel-amqp"),
Map.<String, String> entry("apicurio-registry",
"camel-apicurio-registry"),
Map.<String, String> entry("arangodb", "camel-arangodb"),
- Map.<String, String> entry("as2", "camel-as2"),
Map.<String, String> entry("asterisk", "camel-asterisk"),
Review Comment:
⚠️ **Accidental deletion** — `"as2"` → `"camel-as2"` has no connection to
OGNL removal. `camel-as2` is still an active component. This mapping, along
with `avro`, `box`, `dhis2`, `fhir`, `knative`, `olingo2`, `olingo4`,
`salesforce`, `servicenow`, `fhirJson`, and `fhirXml`, were removed from
multiple hunks in this file but are unrelated to the PR scope. Please restore
them (keep only the `ognl` → `camel-ognl` removal).
##########
core/camel-util/src/main/java/org/apache/camel/util/SensitiveUtils.java:
##########
@@ -90,26 +90,19 @@ public final class SensitiveUtils {
"knownhostsfile",
"knownhostsuri",
"mongodbpassword",
- "oauthclientid",
"oauthclientsecret",
Review Comment:
⚠️ **Security regression** — `oauthclientid` is a sensitive parameter name
that should be masked in logs and diagnostics. This entry, along with
`oauthtokenurl`, `personalaccesstoken`, `privatekeyfile`, `privatekeypassword`,
`proxyuser`, `publickeyid`, and `userpassword`, were removed from this hunk but
have no relation to OGNL. Removing them from `SENSITIVE_KEYS` and
`SENSITIVE_PATTERN` means these credential-bearing options will appear in
plaintext in log output. Restore all of them.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
