gnodet-bot commented on code in PR #29423:
URL: https://github.com/apache/camel/pull/29423#discussion_r4507421580


##########
dsl/camel-jbang/camel-jbang-plugin-tui/src/main/java/org/apache/camel/dsl/jbang/core/commands/tui/ChaosTab.java:
##########
@@ -746,6 +746,14 @@ static String sparkline(long[] values, int width) {
     }
 
     /** A time for a column: 800ms, 2s, 1m4s, 2h3m. */
+    /**
+     * The time until something happens, in whole seconds rounded up: {@code 
back in 1s}, not {@code back in 903ms},
+     * which a narrow note column cuts to {@code 903m} (read as minutes).
+     */
+    static String countdown(long ms) {

Review Comment:
   ⚠️ **Javadoc orphaned from `shortTime()`**
   
   Inserting `countdown()` between `shortTime()`'s existing Javadoc and its 
declaration severs the attachment. Java assigns each `/** */` block to the 
**immediately following** declaration — after this change, the layout is:
   
   ```
   /** A time for a column: 800ms, 2s, 1m4s, 2h3m. */  ← shortTime's old Javadoc
   /** The time until something happens... */             ← countdown's new 
Javadoc (you added)
   static String countdown(long ms) { ... }
   static String shortTime(long ms) { ... }               ← now has no Javadoc
   ```
   
   Move the existing `/** A time for a column… */` to just above `static String 
shortTime` (below the `countdown` block) so it stays attached.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to