Dhairya-007 commented on PR #29419: URL: https://github.com/apache/camel/pull/29419#issuecomment-6722889986
Thanks @davsclaus — done, both as asked. **netty-http `logWarnOnBadRequest`:** unchanged, field initialised to `true`, upgrade guide entry kept. **camel-http `multiline`:** switched to your direction. The annotation is now `defaultValue = "false"` and the field is left alone, so nothing changes at runtime, and the camel-http upgrade guide entry is dropped. Your interleaving argument is the convincing part — with `multiline=true` only the first event carries the exchange id and route, so concurrent calls cannot be told apart in the log. `LoggingHttpActivityListenerTest` now asserts `multiline` as `false`, which pins the metadata to that behaviour. I regenerated the two `LoggingHttpActivityListener.json` bean-metadata copies so `multiline` reads `"defaultValue": false`, and verified they stay byte-identical to each other. They are hand-edited, though — there is no Maven on this machine and building camel-http pulls most of Camel at the current SNAPSHOT — so the CI regen check is the real verification here, not me. On the JIRA: I do not have an Apache JIRA account, so no ticket and no `CAMEL-XXXX:` prefix yet. If you file one, or give me the number, I will amend the commits. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
