oscerd commented on PR #29245: URL: https://github.com/apache/camel/pull/29245#issuecomment-6684567241
@davsclaus thanks for the reviews. Both points are addressed in 1da13c4ce022, on top of a rebase on main with the test-infra metadata regenerated: - **Checkpoint store:** against Azure, `EventHubsConsumerIT` and `EventProcessorIT` build the checkpoint store from the Blob options again (`blobContainerName`, `blobAccountName` and `blobAccessKey` on the endpoint, `setBlob*` on the configuration), so the default checkpoint store keeps its IT coverage. `checkpointStore` is injected only for the local service, as the component builds its Blob client only for `*.blob.core.windows.net`. - **Duplication with #29247:** `FlociAzContainer` now has `withDockerSocket()` (the Docker-socket bind with SELinux labeling disabled, a resource namespace per container, the label registered with the resource reaper on `start()`, and the containers that Floci AZ started removed on `stop()`) and `withBrokerImage(variable)`, which pulls the Artemis image with `RemoteDockerImage`, as #29247 did, and hands it to Floci AZ. The image is one pinned key, `azure.broker.container`, next to `azure.container` in azure-common. The Event Hubs and Service Bus services both use them; the Service Bus module drops its own key and cleanup. Event Hubs: the 8 ITs pass against Floci AZ. Service Bus on the shared support: 13 pass, 9 remote only, as before. No broker container is left after a run, and the regenerated metadata keeps every service version (Floci AZ 0.16.0, Azurite 3.37.0, Artemis unchanged). _Claude Code on behalf of Andrea Cosentino_ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
