Dhairya-007 commented on PR #29418: URL: https://github.com/apache/camel/pull/29418#issuecomment-6722888253
Thanks @davsclaus — both points confirmed, and I checked them rather than taking them on trust. **1. The starter breakage is real.** `SpringBootAutoConfigurationMojo` does `setLiteralInitializer(enumShortName + "." + option.getDefaultValue())`, and `ServiceBusComponentConfiguration` today holds `private AmqpTransportType amqpTransportType = AmqpTransportType.AMQP;`. My change would have regenerated that as `AmqpTransportType.Amqp`, plus `ConsistencyLevel.Session` and `BlockListType.committed`. I have reverted all four Azure options and kept only `cookieSameSite` and `queueConsumerMode`, which have no `componentProperties` entry and so never reach that generator. I would rather not patch the generator from here, since it lives in camel-spring-boot and the fix is a judgement call (resolve the constant by `name()`, or stop deriving the `enum` list from `toString()`). Happy to open something there if you would like it. **2. The stale DSL javadoc was my miss.** Your bot's Regen commit is merged into this branch and supplies the `Default:` lines; I had only updated the description prose and missed that the generator writes the default into the javadoc too. One thing to be explicit about: I cannot run `./etc/scripts/regen.sh` — no Maven here, and building these modules pulls most of Camel at the current SNAPSHOT — so the generated files in this PR are hand-edited. I checked that each component json and its camel-catalog copy stay byte-identical, line counts are unchanged and there are no whitespace changes, but please lean on the CI regen check rather than on me. On the JIRA: I do not have an Apache JIRA account, so I have not opened a ticket or used a `CAMEL-XXXX:` prefix. If you file one or pass me the number I will amend the commits. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
