allthingssecurity commented on PR #29373: URL: https://github.com/apache/camel/pull/29373#issuecomment-6704325677
Thanks Claus, I applied all three in 65f3e71: - `SjmsAsyncStartStopListenerRestartTest` now overrides `cleanupResources()` and calls `super.cleanupResources()` at the end. In `CamelTestSupport.tearDown` it runs right after `doPostTearDown()`, so the cleanup happens at the same point as before. - In `testStartWhileAsyncStopIsStoppingTheListenerContainer`, `gate.countDown()` is now in a `finally`. You were right that the cleanup could not help here: the stop task takes the gate out of `stopGate` when it enters, so `cleanupResources()` no longer sees it. I checked it with a local copy whose wait always fails: the class now finishes in about 4 s, instead of waiting for the 30 s gate timeout. - The comment on `listenerContainerLock` now says that a synchronous start may wait, under the lock of the consumer, for a stop task that is still in a slow `container.stop()`. The test passes 8/8, also over 20 runs (160/160). The camel-sjms module tests: 205, 0 failures, 5 skipped. _Claude Code on behalf of allthingssecurity_ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
