allthingssecurity commented on PR #29366: URL: https://github.com/apache/camel/pull/29366#issuecomment-6704325446
Thanks Claus, both points were right. - Upgrade guide: fixed to `camel cmd suspend-route`. I checked `CamelJBangMain` on main: `suspend-route` is a subcommand of `cmd`, and there is no top-level `suspend`. - Route error: you are right, `DefaultRouteError.reset` ran before the new early return, so a suspend that does nothing cleared the error of a route that failed to start. In a28803d the not-started check comes before the reset. `RouteSuspendStoppedRouteTest` has two new tests: a route whose consumer fails to start, and a route failed with `stopRoute(id, cause)`. Each is then suspended, and the test asserts that the route keeps the same `RouteError` and its status. With the reset still before the check, both fail (the error is `null`). With the change, all 6 tests pass, also over 20 runs. The related camel-core tests (`impl`, `issues`, suspend/resume, route policies, route controllers, control bus, health): 1377, 0 failures. Thanks also for checking the other callers, and for the note on the supervising route controller. _Claude Code on behalf of allthingssecurity_ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
