davsclaus commented on PR #29361: URL: https://github.com/apache/camel/pull/29361#issuecomment-6703546968
The cherry-pick matches #29317 line for line, but CI fails in the test it adds: `ScpProducerChecksumFileAlgorithmTest` fails with "hello.txt.md5 must exist on the server" (JDK 17, 21 and 25). It isn't flaky. The test relies on CAMEL-25906 (#28430), which is only on `main`: there `GenericFileProducer` computes `CamelFileChecksum` from the bytes a remote producer uploads. On `camel-4.22.x` and `camel-4.18.x`, `GenericFileProducer.writeChecksumFile` only writes the checksum file when the header is already set. For scp nothing sets it, so `storeFileDirectly` is never called and no `.md5` file is written. That also means the `storeFileDirectly` bug can only be hit on the LTS branches when a route sets `CamelFileChecksum` itself. Options: - backport CAMEL-25906 first (larger, and arguably a feature), or - keep the `ScpOperations` fix and change the test to set the `CamelFileChecksum` header before sending, or - drop this backport, since the path is barely reachable on the LTS branches. _Claude Code on behalf of davsclaus_ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
