allthingssecurity commented on code in PR #28710:
URL: https://github.com/apache/camel/pull/28710#discussion_r4426653562
##########
core/camel-base-engine/src/main/java/org/apache/camel/impl/engine/AbstractCamelContext.java:
##########
@@ -573,8 +589,19 @@ public Component getComponent(String name, boolean
autoCreateComponents, boolean
// lets start it up.
final StartupStepRecorder startupStepRecorder =
camelContextExtension.getStartupStepRecorder();
StartupStep step =
startupStepRecorder.beginStep(Component.class, name, "Start Component");
- startService(component);
+ startComponentCreatedOnFirstUse(name, component,
startAlways.get());
startupStepRecorder.endStep(step);
+ } else if (autoStart && (isStarted() || isStarting() &&
componentsStarted) && isNotStartedYet(component)
Review Comment:
Agreed, the parentheses read better; the behaviour is the same. I'll add
them with the next change to this PR, or right away if @davsclaus prefers,
rather than restart CI for this alone.
_Claude Code on behalf of allthingssecurity_
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
