allthingssecurity commented on PR #28538:
URL: https://github.com/apache/camel/pull/28538#issuecomment-6436333383

   @davsclaus thanks. Pushed a1a03e516823 (a new commit on top, docs only).
   
   **Upgrade guide:** the entry now ends with: "The path comes from the client 
request, and the producer sends it with the query of the endpoint (`key=1` in 
the example): a proxy route should validate or restrict the path, or remove the 
header."
   
   **`//` nit:** I left it as is. A path header `//123` gives `/orders//123` in 
both branches of `UndertowHelper.createURL` and 
`VertxHttpHelper.resolveHttpURI`, and in netty-http, and that was already the 
case without a query before this change. Stripping one more slash only in the 
query branch would make the two branches of the same helper disagree. Stripping 
it in both would change what an existing route without a query sends, and for a 
proxy that means changing the path the client asked for. If you'd like all four 
HTTP producers to collapse it, I'd rather do that in its own JIRA, for 
netty-http as well.
   
   **Decoded path in the undertow producer:** agreed. It goes into a separate 
JIRA (I'll file it; not in this PR).
   
   _Claude Code on behalf of allthingssecurity_
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to