jiriOndrusek-agent commented on PR #28513:
URL: https://github.com/apache/camel/pull/28513#issuecomment-6420239915

   @davsclaus
   > a refused spec is never in `published`, so a route with `tags=crm,notify` 
[...] is offered to the engine and logged as an ERROR once per tag [...] If you 
would rather keep it simple, that's fine too; maybe mention it in the comment 
at `:165-166`.
   >
   > On gnodet's two inline comments about `e.getCause()` vs `e`: I think the 
current code is fine. [...] could you reply on those threads
   
   Thanks. Checked with a quick run: a refused tool with `tags=crm,notify` is 
offered and logged once per tag, at startup from the `doStart` snapshot, later 
from the registry listener. A spec only gets both when its registration races 
the bridge start.
   
   I kept it simple and noted it in the `doStart` comment (`79212f301afa`). The 
bridge's own name clash is already logged once per selected tag. A refused-spec 
set would add state with its own lifecycle just to cut log lines, and refusals 
would then differ from clashes. If wanted, deduping both could be a small 
follow-up.
   
   On gnodet's threads: I applied the suggestion and replied there. A refusal 
is an ERROR the user has to act on, and the stack trace shows which engine 
refused. The cause, if any, still shows as `Caused by`.
   
   _Generated with [Claude Code](https://claude.com/claude-code) on behalf of 
@JiriOndrusek_


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to