gnodet-bot commented on code in PR #28527:
URL: https://github.com/apache/camel/pull/28527#discussion_r4378553796
##########
components/camel-as2/camel-as2-component/src/main/java/org/apache/camel/component/as2/AS2Configuration.java:
##########
@@ -757,12 +759,14 @@ public String getAsyncMdnAllowedHosts() {
}
/**
- * Comma separated list of host names an asynchronous MDN may be delivered
to. The delivery address is chosen by the
- * sender of the AS2 message, so this is the list of hosts the operator
vouches for.
+ * Comma separated list of hosts an asynchronous MDN may be delivered to.
The delivery address is chosen by the
+ * sender of the AS2 message, so this is the list of destinations the
operator vouches for. Each entry is a host
Review Comment:
💡 The updated Javadoc documents `host:port` form but doesn't mention IPv6
bracket notation. Operators using IPv6 delivery addresses won't know the
correct format (`[::1]` or `[::1]:8443`).
```suggestion
* Comma separated list of hosts an asynchronous MDN may be delivered
to. The delivery address is chosen by the
* sender of the AS2 message, so this is the list of destinations the
operator vouches for. Each entry is a host
* with an optional port in host:port form (IPv6 literals use bracket
notation, for example [::1] or [::1]:8443);
* a bare-host entry (for example partner.example) matches only the
default port for the scheme (80 or 443), so a
* non-default port is listed explicitly (for example
partner.example:8443).
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
