etzel-mes opened a new pull request, #28514: URL: https://github.com/apache/camel/pull/28514
# Description Items 1 and 2 of CAMEL-26179; item 3 (milo-server) is left to the reporter. 1. A write of a body that the client cannot encode no longer drops the shared connection since CAMEL-25912 (#28371): a failed producer request completes with its failure and does not rebuild the connection. This adds the regression test `ProducerOnSharedConnectionTest.writeOfABodyThatCannotBeEncodedKeepsTheConnection`: an awaited write of a `Map` body fails with `UaSerializationException`, the consumer of another node on the same connection receives only its next value (no `Bad_NoCommunication`, no resent value over 2 s), and a following write on the same client and session answers `GOOD`. It fails when `outcomeOf` calls `handleConnectionFailure` again as before CAMEL-25912. 2. A `milo-client` write of a `null` body now fails the exchange with an `InvalidPayloadException` before anything is sent, awaited or not. Before, it wrote a null value, which the server refused with `Bad_TypeMismatch`, and an awaited write completed without an error and with that status as the body. A `DataValue` or `Variant` body still writes a null value explicitly (the exception hint says so). A method call with a `null` body is unchanged: it calls the method without input arguments, as documented. Test: `WriteClientTest.testWriteNullBodyFails` (awaited and not awaited), which fails on the unmodified code. Docs: one paragraph in the milo-client component doc (and its catalog copy) and a section in the 4.24 upgrade guide. Module `-Psourcecheck verify` with `-Dsurefire.rerunFailingTestsCount=0`: 128 tests, 0 failures, 1 skipped (as upstream); the two changed classes green in 3 further runs. Fixes CAMEL-26179. @davsclaus @oscerd # Target - [x] I checked that the commit is targeting the correct branch (Camel 4 uses the `main` branch) # Tracking - [x] If this is a large change, bug fix, or code improvement, I checked there is a [JIRA issue](https://issues.apache.org/jira/browse/CAMEL) filed for the change (usually before you start working on it). # Apache Camel coding standards and style - [x] I checked that each commit in the pull request has a meaningful subject line and body. - [ ] I have run `mvn clean install -DskipTests` locally from root folder and I have committed all auto-generated changes. # AI-assisted contributions - [x] If this PR includes AI-generated code, commits have proper co-authorship attribution (e.g., `Co-authored-by` trailers) and the PR description identifies the AI tool used. _Claude Code on behalf of etzel-mes_ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
