Croway opened a new pull request, #28506:
URL: https://github.com/apache/camel/pull/28506

   Jira: https://issues.apache.org/jira/browse/CAMEL-25917
   
   Backport of #28237 to `camel-4.18.x` (cherry-pick of 56aa5f4970a6).
   
   On a WebSocket path whose producer applies a security provider or allowed 
roles, a connection accepted while only the producer served the path, before 
its consumer was first started, did not run the custom `handlers` that the 
consumer configures. Once the consumer started, that connection was still 
served. The handshake result now records whether it ran in consumer mode, so 
such a connection is no longer served once a consumer with `handlers` is up, 
and the consumer closes it as soon as it starts. The window tests send on that 
connection on a best effort basis, since it may already be closed.
   
   - `camel-4x-upgrade-guide-4_24.adoc` does not exist on this branch, so it is 
left out. On this line, the `handlers`, `allowedRoles` and security provider 
options apply to WebSocket endpoints from 4.18.6 on (CAMEL-25375), so the 
doc-sync PR on `main` extends the existing 4.18.6 camel-undertow WebSocket 
entry.
   - `UndertowWsOAuthProfileConsumerWindowTest` does not exist on this branch 
(the `oauthProfile` support of CAMEL-23723 is not on 4.18.x), so its change is 
left out.
   - `CamelWebSocketHandler` applied without a textual conflict. This branch 
has no OAuth checks in the handler, so the change only touches the handshake 
result, `isAuthenticated` and the new close of the peers when the consumer is 
set, as on `main`.
   
   Tests: `components/camel-undertow` `mvn verify` on this branch: BUILD 
SUCCESS, 199 tests, 0 failures, 1 skipped (including 
`SecurityProviderWebSocketConsumerHandlersWindowTest` and 
`UndertowWsSecurityWithoutProviderTest`)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to