ramu11 commented on PR #28354: URL: https://github.com/apache/camel/pull/28354#issuecomment-6409522849
This commit 79a1667 addresses the latest review feedback for your tool-search implementation. Changes included 1. Fix OpenAI tool-search session restoration Updated OpenAIProducer.java and OpenAIResponsesProducer.java to preserve the exact AiToolSearchSession that existed before a producer step. - Save the previous session before calling openSession(). - Restore the original session in finally if one existed. - Otherwise, close the step's session using the existing cleanup policy. This prevents a memory-enabled step using CamelOpenAIToolSearchSessionId from replacing an exchange-local session and losing its earlier discoveries. 2. Add session-lifecycle regression coverage Updated OpenAIToolSearchMockTest.java with a scenario that switches from an exchange-local session to an ID-based session, then runs a non-memory chat step and tool execution. The test checks that the earlier invoice discovery remains advertised and that the original session object is restored. 3. Test LangChain4j customizer precedence Updated LangChain4jAgentToolSearchTest.java to verify that a user-provided aiServicesCustomizer still runs, but the endpoint's configured tool-search strategy takes precedence over a strategy supplied by the customizer. 4. Consolidate documentation Updated the OpenAI MCP documentation and its generated catalog copy. The session-isolation advice now lives in the existing Tool search section, recommending distinct session IDs when endpoints have different tags or MCP filters. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
