oscerd commented on PR #28094: URL: https://github.com/apache/camel/pull/28094#issuecomment-6290440692
Rebased onto `main` and pushed one more commit. - **Rebase.** The only conflict was the 4.24 upgrade guide, where several camel-pqc PRs had added their note at the same spot. This note now sits before the `camel-jbang - camel get endpoint shows the scope of an endpoint` section, at a different place from the other open camel-pqc PRs, so they stop conflicting with each other. - **Open point from the review of #28099.** The `klm.getKeyMetadata(keyId)` read before the usage write was unguarded, so a vault that could not be read failed the exchange of a non-stateful key although only its usage count was at stake. The commit "CAMEL-25797: Address review feedback - a failed metadata read for a non-stateful key keeps the signature" treats the read like the write: logged once per producer (shared `warnUsageRecordFailure`), signature kept. A stateful key still fails the exchange, as its index must be persisted. `KeyRotationSignalsTest.aFailedMetadataReadKeepsTheSignatureOfAStatelessKey` covers it with an in-memory manager whose reads can be made to fail: the exchange reaches the mock with its signature, and the usage count stays at zero. That test goes through an endpoint with `strictKeyLifecycle=false`, because the key status check before signing is a deliberate fail-closed read of the same metadata; with it off, the usage read is the exchange's only vault re ad. The lifecycle page and the upgrade-guide note now say "read or write". #28099 is rebased on top of this commit, so the fix reaches it too. Verification: camel-pqc on JDK 21 (`mvn clean install`) and JDK 25 (`mvn test`: 277 tests, 0 failures); full reactor `mvn clean install -DskipTests -DskipITs` `BUILD SUCCESS`, no regenerated-file drift. _Claude Code on behalf of oscerd_ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
