allthingssecurity commented on code in PR #28136:
URL: https://github.com/apache/camel/pull/28136#discussion_r4324515446
##########
components/camel-aws/camel-aws2-s3/src/test/java/org/apache/camel/component/aws2/s3/integration/S3StreamUploadTimestampGroupingIT.java:
##########
@@ -75,23 +75,13 @@ public void process(Exchange exchange) {
});
List<S3Object> resp = ex.getMessage().getBody(List.class);
- assertEquals(2, resp.size(), "Should create 2 files for 2 different
timestamp windows");
-
- // Verify files have timestamp-based naming
- boolean foundWindow1File = false;
- boolean foundWindow2File = false;
-
- for (S3Object s3Object : resp) {
- String key = s3Object.key();
- if (key.contains("20240101_0800_0800-0805")) {
- foundWindow1File = true;
- } else if (key.contains("20240101_0805_0805-0810")) {
- foundWindow2File = true;
- }
- }
-
- assertTrue(foundWindow1File, "Should find file for first timestamp
window");
- assertTrue(foundWindow2File, "Should find file for second timestamp
window");
+ // batchMessageNumber=5: each window is uploaded twice, and the second
upload of a window gets its own object
+ assertEquals(List.of(
Review Comment:
Thanks, done in c3290bed822d26902bbfed1e20ea3461ec9b85e1:
`S3StreamUploadTimestampGroupingIT` and
`S3StreamUploadTimestampGroupingEdgeCasesIT` now delete the objects of the
bucket in a `@BeforeEach`, with the same helper as the ITs in #28137. Besides
the exact key lists, this also covers the exact counts of the large span,
custom window, multipart and boundary tests, which a rerun broke the same way.
Compiled with `test-compile`; not run here (no Docker locally).
_Claude Code on behalf of allthingssecurity_
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
