davsclaus commented on code in PR #28138: URL: https://github.com/apache/camel/pull/28138#discussion_r4322887673
########## components/camel-test/camel-test-dst/src/main/docs/test-dst.adoc: ########## @@ -305,6 +309,27 @@ Agents wrote nine worlds with this guide. These mistakes came up: CAMEL-25737 (`visibilityTimeout=1`) and CAMEL-25741 (aws2-ddbstream, found with a fake DynamoDB Streams world) were found. +These came up when writing worlds for IMAP, JMS, NATS JetStream and Azure Service Bus: + +* *An empty answer at once.* A fake that answers at once with nothing (no message, no responder) lets the consumer + poll in a tight loop in which virtual time does not move, so the run never gets to its end. Give every call of the + fake a round-trip latency. Review Comment: Nit: "the run never gets to its end" applies to a consumer with its own receive loop (JMS, NATS fetch); a scheduled-poll consumer still moves time through its `delay`. In practice the seed fails rather than hangs, on the step budget or the `DstWatchdog`. Maybe: "lets a consumer with its own receive loop spin without virtual time moving; the seed fails on the step budget or the watchdog instead of reaching its end." ########## components/camel-test/camel-test-dst/src/main/docs/test-dst.adoc: ########## @@ -305,6 +309,27 @@ Agents wrote nine worlds with this guide. These mistakes came up: CAMEL-25737 (`visibilityTimeout=1`) and CAMEL-25741 (aws2-ddbstream, found with a fake DynamoDB Streams world) were found. +These came up when writing worlds for IMAP, JMS, NATS JetStream and Azure Service Bus: Review Comment: Nit: Service Bus is already one of the "nine worlds" listed above. Could this read "Later worlds (IMAP, JMS, NATS JetStream, Azure Service Bus) showed more:", or fold these into the one list? Otherwise a reader can't tell whether these are four more worlds or the same ones. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
