squakez commented on PR #6893: URL: https://github.com/apache/camel-k/pull/6893#issuecomment-6284833600
> Thanks @squakez! I checked the Pipe → Integration conversion: the ArkMQ binding produces `amqp:queue:my-queue` plus the `camel.component.amqp.broker-url` property. I'm planning to let the KEDA mapper read `camel.component.<scheme>.*` properties so the artemis scaler can derive `managementEndpoint` from the broker URL host + port 8161. > > A few questions before I push: > > 1. Should the endpoint be the headless service host or the pod FQDN (`<cr>-ss-0...`), given the Jolokia origin check? > > 2. Is it ok to default `brokerName` to `amq-broker`, or keep it in `autoMetadata`? > > 3. Since auto-discovered triggers can't carry the console credentials, is a ScaledObject-only e2e check enough for this PR? It could be a good idea to also use application properties to extract mapping configuration. However it may require some change in the original architecture to pass a new map to the scaler. Feel free to provide some proposal. The host should be the one coming from the configuration (mind that it could even be an Integration, not only a Pipe). Any other parameter has to be recovered automatically from the Integration as well as credential if they are present. However, given this is a first implementation you may let the credentials setting out of the implementation. A good sample to get some inspiration is in the e2e Kafka scaler test. We should try to replicate the same logic, but using the new scaler instead. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
