oscerd opened a new pull request, #28161:
URL: https://github.com/apache/camel/pull/28161

   ## Backport of #28095
   
   **Original PR:** #28095 - CAMEL-25787: camel-smooks - handle Smooks Source 
bodies like other XML message bodies
   **Original author:** @oscerd
   **Jira:** [CAMEL-25787](https://issues.apache.org/jira/browse/CAMEL-25787)
   **Target branch:** `camel-4.18.x` (4.18.6)
   
   Cherry-pick (`git cherry-pick -x`) of `a439c1ab3912`, the squash merge of 
#28095 on `main`, adapted for this branch.
   
   ### Adapted, not a straight cherry-pick
   
   - The new tests `SmooksSourceBodyTest` and `SmooksReaderConfigTest` extend 
`org.apache.camel.test.junit5.CamelTestSupport` instead of 
`org.apache.camel.test.junit6.CamelTestSupport`, because `camel-smooks` uses 
`camel-test-junit5` on this branch. These two import lines are the only 
difference from #28095 under `components/camel-smooks`.
   - Left out: the hunk in `camel-4x-upgrade-guide-4_24.adoc`, a file that does 
not exist on this branch. The upgrade guides live on `main`, where the note for 
4.18.6 goes into `camel-4x-upgrade-guide-4_18.adoc` separately.
   
   `SmooksProcessor.java` and `SmooksSecuritySupport.java` were identical on 
`main` and `camel-4.18.x` before the change, so the code under `src/main` is 
the same as in #28095. Because the tests had to change, this backport gets a 
normal review.
   
   ### Tests
   
   - `camel-smooks`: 43 tests, 0 failures, 0 errors: the 32 existing tests and 
the 11 new ones in `SmooksSourceBodyTest` and `SmooksReaderConfigTest`.
   - With the code under `src/main` as it is on `camel-4.18.x`, 9 of the 11 new 
tests fail, as on `main`. The other two check behaviour the change keeps: a 
byte order mark, and `DOMSource` and `JavaSource` bodies.
   - Full reactor build with `-DskipTests -DskipITs`: success, with no 
regenerated files.
   
   _Claude Code on behalf of oscerd_
   
   🤖 Generated with [Claude Code](https://claude.com/claude-code)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to