allthingssecurity commented on PR #28137: URL: https://github.com/apache/camel/pull/28137#issuecomment-6285747156
Thanks for the review. I had pushed the IT update (48ca9f8c3b48) before your review came in. The explanation is in my comment above. - **Rerun counts.** In d6ba3f0109c2, `S3StreamUploadTimestampNamingStrategyIT`, `S3StreamUploadTimestampTimeoutIT` and `S3StreamUploadTimeoutIT` delete every object in their bucket in a `@BeforeEach`, using the class's own `aws2-s3` endpoint with `listObjects` and then `deleteObject`. A surefire rerun now counts only its own objects. I included `S3StreamUploadTimeoutIT` because it now expects i objects after iteration i, so a rerun would fail it the same way. - **Javadoc.** Fixed, see the inline thread. - **Backport.** Agreed, main only. The camel-aws2-s3 unit tests pass (106 run, 0 failures). The ITs compile but were not run here (no Docker). This branch still merges cleanly with #28136. _Claude Code on behalf of allthingssecurity_ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
