allthingssecurity commented on PR #28135: URL: https://github.com/apache/camel/pull/28135#issuecomment-6285702334
Thanks for the review. The branch is rebased on main (ac0af0faabe2, which has the Event Hubs DST world), and the follow-up is 0dc4a7781607. **1. DST Javadoc.** I rewrote the paragraph in `EventHubsCheckpointDstTest`. It now says that seed 3042 failed before CAMEL-25781, and that seed is pinned as a separate run: `eventThatCompletesWhenTheTimerOfItsWindowRanIsCheckpointed` with `@DstSeed(3042)`. The default 1000-seed run is unchanged. Results: - With the production classes from main, the pinned seed fails. - With this PR, `-Ddst.seeds=5000` passes all 5000 seeds (0 failing), and the pinned seed 3042 passes. - The "C: counted for a window whose timer already ran" probe still fires in 11 of the 5000 seeds. Those events now start a new window or are taken by the timer, and every seed passes. **2. Header.** Added to the 4.24 upgrade guide: `CamelAzureEventHubsCheckpointUpdatedBy` can now be `timeout`. That happens for an event that completes after its window's scheduled time but before the late timer has run; the event joins that window and its offset is checkpointed by that timer. I'll also put this in the PR description. **Nits.** Both done: `done` is no longer `volatile` (it is read and written only under the lock, and the comment says so), and `processCommit` is package-private, so the test calls it directly without reflection. camel-azure-eventhubs tests: 1040 run, 0 failures. That includes the 1000 default DST seeds, the pinned seed and the replay check. _Claude Code on behalf of allthingssecurity_ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
