allthingssecurity opened a new pull request, #28139: URL: https://github.com/apache/camel/pull/28139
# Description [CAMEL-25822](https://issues.apache.org/jira/browse/CAMEL-25822) Test only. The SQS world shipped with `camel-test-dst` (CAMEL-25738, `SqsVisibilityDstTest` / `SqsWorld`) ended its drain phase after a fixed virtual time, `20 * visibilityTimeout + 30` s after the faults were switched off. A slow configuration can still be deleting messages when that time runs out, and the seed then fails although nothing is lost. On main, 1 of 20,000 seeds fails: seed 9667 (`visibilityTimeout=2 maxMessagesPerPoll=1 concurrentConsumers=1 delay=1000`), `every offered message is routed at least once: 1 never routed: [q/m41]`, trace hash `dd65c816de75...` on two replays. The consumer deletes a message about every 1.2 s up to the check; the last one would have been deleted 1.1 s after it. Change (`SqsWorld`): - The drain runs while it makes progress: it stops when the queue is drained, when no message was deleted for `20 * visibilityTimeout + 30` s (the old fixed length, now measured from the last delete), or at a cap of one hour of virtual time. - The invariants are unchanged. - The guide's snippet of the drain phase in `test-dst.adoc` shows the new loop, with one sentence on why; the catalog copy is updated the same way (byte-identical). Tests: - Seed 9667 passes with the change, with the same trace hash on two replays. - 20,000 seeds: 0 failing (main: 1). - Self-check, the CAMEL-25700 fix reverted locally: 1397 of 5000 seeds fail, all "no message is delivered again while the consumer holds it", the same count as before this change and as the guide states. # Target - [x] I checked that the commit is targeting the correct branch (Camel 4 uses the `main` branch) # Tracking - [x] If this is a large change, bug fix, or code improvement, I checked there is a [JIRA issue](https://issues.apache.org/jira/browse/CAMEL) filed for the change (usually before you start working on it): [CAMEL-25822](https://issues.apache.org/jira/browse/CAMEL-25822). # Apache Camel coding standards and style - [x] I checked that each commit in the pull request has a meaningful subject line and body. - [ ] I have run `mvn clean install -DskipTests` locally from root folder and I have committed all auto-generated changes. (I ran the SQS world with camel-test-dst and camel-aws2-sqs. Only a test class and the guide page with its catalog copy changed. I did not run the full root build.) # AI-assisted contributions - [x] If this PR includes AI-generated code, commits have proper co-authorship attribution (e.g., `Co-authored-by` trailers) and the PR description identifies the AI tool used. This PR was prepared with Claude Code (Claude Opus 5.5). The commit carries a `Co-Authored-By` trailer. _Claude Code on behalf of allthingssecurity_ 🤖 Generated with [Claude Code](https://claude.com/claude-code) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
