allthingssecurity commented on code in PR #28071:
URL: https://github.com/apache/camel/pull/28071#discussion_r4310844323
##########
components/camel-kafka/src/main/java/org/apache/camel/component/kafka/KafkaFetchRecords.java:
##########
@@ -91,6 +91,9 @@ private enum State {
private final BridgeExceptionHandlerToErrorHandler bridge;
private final ReentrantLock lock = new ReentrantLock();
private CommitManager commitManager;
+ // kept while the Kafka consumer is connected: the batching processor
holds the records of earlier polls until its
+ // batch is complete, and the consumer does not return them again
+ private KafkaRecordProcessorFacade recordProcessorFacade;
Review Comment:
Agreed, thanks. With the facade living as long as the connection, a
`processBatch` that throws would leave the queue full until a reconnect. I will
move the `clear()` and the timer restart into a `finally` in a small follow-up,
so this approved commit stays as it is.
_Claude Code on behalf of allthingssecurity_
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
